Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • O ogs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 112
    • Issues 112
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 43
    • Merge requests 43
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • ogsogs
  • ogs
  • Merge requests
  • !4302

[PL/BC] Reimplement Robin-type BC

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dmitry Yu. Naumov requested to merge endJunction/ogs:2DRobinManufacturedSolutionTest into master Sep 29, 2022
  • Overview 17
  • Commits 6
  • Pipelines 7
  • Changes 36

The former implementation did not produce expected results for 2D and 3D case. Rewriting and implementing the Jacobian for the Newton scheme. Keeping K matrix for the Picard scheme as applying the BC to the r.h.s. only significantly increases number of non-linear iterations because the problem becomes non-linear.

A method of manufactured solutions is used to verify implementation of the Robin-type boundary condition. Grid convergence was assessed and the observed order of convergence is 1.99, which, as expected, is close enough to 2.

In the same setup a Neumann and Dirichlet-type boundary conditions can (and were) tested with same convergence order as the Robin-type BC.

The test is testing both non-linear solver schemes, Newton and Picard. With the new implementation of the Robin-type BC the convergence rates of the non-linear solver are satisfying, usually 2 iterations per time step for both schemes.

Four tests testing the axisymmetry were updated, three of them verified against a given manufactured solution, and the TES one is relying on the numerical results, i.e. the 3D solution was mapped to 2D axisymmetric case and is used as reference.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?

Review commit-wise. Many details are provided in the commit messages.

Edited Oct 20, 2022 by Dmitry Yu. Naumov
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 2DRobinManufacturedSolutionTest