[base] Improved path validation

R/scrape_benchmarks.R

@@ -8,13 +8,7 @@ scrape_benchmarks <- function(
     url = "https://gitlab.opengeosys.org/ogs/ogs/-/tree/master/Tests/Data/",
     path = "extdata/benchmarks/") {
 
-    assertthat::assert_that(assertthat::is.string(path))
-
-    last_char_index <- length(path)
-
-    if(substring(path, last_char_index, last_char_index) != "/"){
-        path <- paste0(path, "/")
-    }
+    path <- validate_is_dir_path(path)
 
     data_page <- xml2::read_html(url)
 
@@ -40,13 +34,8 @@ scrape_benchmarks <- function(
 download_benchmark <- function(prj_url, path) {
 
     assertthat::assert_that(assertthat::is.string(prj_url))
-    assertthat::assert_that(assertthat::is.string(path))
 
-    last_char_index <- length(path)
-
-    if(substring(path, last_char_index, last_char_index) != "/"){
-        path <- paste0(path, "/")
-    }
+    path <- validate_is_dir_path(path)
 
     prj_dest_file <- paste0(path, basename(prj_url))
     file.create(prj_dest_file)