The argument characterizes the direction the layer is added - either on top or on bottom.

Use directly addLayerToMesh.

Tom Fischer authored 4 years ago and Dmitri Naumov committed 4 years ago

This fixes at least in one example the issues.

The fmt library happily accepts std::string without
any conversions.

joerg authored 4 years ago and Dmitri Naumov committed 4 years ago

remove old function/complete replace of getNumberOfElementTypes()

tiny change

add getNumElemType function based on ordered map

remove old function/complete replace of getNumberOfElementTypes()

tiny change

make all number of element type maps const references

add missing auto

throw check mesh printing routines into MeshInformation class

If only file name is specified it causes a warning
about the name not to be specific enough if there is
another file with the same name, e.g.:

the name `IdealGasLaw.h' supplied as the second argument
in the \file statement matches the following input
files: ogs/MaterialLib/Fluid/Density/IdealGasLaw.h
ogs/MaterialLib/MPL/Properties/IdealGasLaw.h
Please use a more specific name by including a (larger)
part of the path!

From now on only \file w/o a name or a full path will
be allowed.

find -type f | xargs sed -i 's%\(\\file\).*%\1%'

Including
 - usage of static_cast instead of c-style cast,
 - single variable declaration per line,
 - removing const from return types
 - omit unnecessary string to char* conversions,

The used clang-tidy checks are:
google-readability-casting,
readability-const-return-type,
readability-container-size-empty,
readability-delete-null-pointer,
readability-deleted-default,
readability-else-after-return,
readability-function-size,
readability-identifier-naming,
readability-inconsistent-declaration-parameter-name,
readability-isolate-declaration,
readability-misleading-indentation,
readability-misplaced-array-index,
readability-named-parameter,
readability-redundant-*,
readability-simplify-*,
readability-static-accessed-through-instance,
readability-static-definition-in-anonymous-namespace,
readability-string-compare,
readability-uniqueptr-delete-release

Most of the current .clang-tidy contained checks:
google-explicit-constructor
google-readability-braces-around-statements
modernize-loop-convert
modernize-use-default-member-init
modernize-use-emplace
modernize-use-using
readability-braces-around-statements
readability-else-after-return
readability-named-parameter
*readability-namespace-comments
*readability-inconsistent-*
readability-redundant-member-init
readability-simplify-boolean-expr
readability-string-compare
*explicit-conversions*

Either by renaming or removing the variable or adding
an extra scope to the top variable.

CPPCheck warning type: shadowVar.

Avoids variable shadowing (vec_bounds).
Simplifies handling of error cases w/o using any
sentinel values.
Using sentinel values for integers or doubles
artificially restricts the range of possible values
used and can lead to unadvert (incorrect) errors.

- remove the twice given command line argument -g
- check if mesh is read