Skip to content
Snippets Groups Projects

[A/IO/GocadIO] Gocadreader - Fix reading line if Gocad file is represented as CR+LF.

Merged Tobias Meisel requested to merge TobiasMeisel/ogs:GocadTSurfaceReader_Linux into master

If Gocad file is represented in windows style CR+LF tokens read may have \r appended. Logic of Gocadreader depending on string comparison will then fail. This merge request does not fix all readlines. Only token that are the last of each line have been affected. e.g. ZPOSITIVE Elevation^M$ ZPOSITIVE is not affected END_ORIGINAL_COORDINATE_SYSTEM^M$ is affected

The alternative of taking a generic approach with rewriting the file was considered, but our tools should be platform agnostic. Better solutions that have std::getline read in without LF must be found with next improvements.

Edited by Tobias Meisel

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading