Fix and test MaterialID in msh2vtu
This introduces more tests to systematically check, if MaterialIDs are properly generated from gmsh physical group tags. Also Fixes a failing case, where a single physical group with a tag != 0 would not reindex to 0 if reindex=True. Also changes the logic from reindex: previously would use a offset to reach 0, i.e. [1,2,4] -> [0,1,3] now it reindexes completely, i.e. [1,2,4] -> [0,1,2]
Merge request reports
Activity
added BugFix workflowin development labels
assigned to @FZill
added 51 commits
-
8849bf0c...96d30fad - 50 commits from branch
ogs/tools:main
- 8cec6b5e - Fix condition
-
8849bf0c...96d30fad - 50 commits from branch
@felikskiszkurno Yes, non-covered code https://ogs.ogs.xyz/-/tools/ogstools/-/jobs/492592/artifacts/htmlcov/z_da877fdd31067d0c___init___py.html, is likely to contain defects.
But, the one test failing, is indeed a test that uses msh2vtu? Could you have look?
Edited by Tobias Meiselassigned to @felikskiszkurno
requested review from @TobiasMeisel
changed milestone to %0.5.0 Release
We should write down some specification what materialIDs we expect under which circumstances, so that we are all in the same boat and don't have expectations which might differ.
Edited by Florian Zilladded 4 commits
-
8cec6b5e...38b831bd - 3 commits from branch
ogs/tools:main
- 54c210a4 - Fix condition
-
8cec6b5e...38b831bd - 3 commits from branch
added 1 commit
- 49b86e59 - [msh2vtu] fix and test generation of MaterialIDs
- Resolved by Florian Zill
added workflowplease review label and removed workflowin development label