Skip to content
Snippets Groups Projects

Lineplots and unit handling

Merged Florian Zill requested to merge FZill/ogstools:lineplots into main
  1. Unit Handling

Previously we defined spatial and temporal units as attributes of the MeshSeries. This was troublesome to convey this information to the plot functions for individual meshes. We now leave it to the user to properly scale their meshseries spatially and temporally in the beginning with the newly implemented MeshSeries.scale function either with scalar factors or with units paris for conversion (input_unit, output_unit). In ot.plot.setup the spatial_unit and time_unit are adde for labeling the plots. If the MeshSeries is scaled with unit pairs the latter unit is also applied in plot.setup.

  1. line plotting

We had a quite convoluted functions and an exampled to plot linesamples. This MR reduces the releveant code to one function which should provide the means to all use cases. The examples is updated accordingly and should give a comprehensive overview.

  1. Feature description was added to the changelog
  2. Tests covering your feature were added?
  3. Any new feature or behaviour change was documented?
  4. API-breaking changes documented here
Edited by Florian Zill

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Feliks Kiszkurno approved this merge request

    approved this merge request

  • Florian Zill added 5 commits

    added 5 commits

    • 7bbfbd09 - [meshlib] add scale function to ms, rm units
    • 11d1cc87 - [plot] simplified line plotting
    • 69662768 - [mypy] show absolute path in output
    • 5520fd0c - [docs] improve feflow example
    • f502bc52 - [docs] added changes to release notes

    Compare with previous version

  • Florian Zill reset approvals from @felikskiszkurno by pushing to the branch

    reset approvals from @felikskiszkurno by pushing to the branch

  • Florian Zill added 1 commit

    added 1 commit

    • a3af3b45 - [docs] use correct RST formatting for inline code

    Compare with previous version

  • Florian Zill resolved all threads

    resolved all threads

  • Florian Zill marked the checklist item Feature description was added to the changelog as completed

    marked the checklist item Feature description was added to the changelog as completed

  • Florian Zill marked the checklist item API-breaking changes documented here as completed

    marked the checklist item API-breaking changes documented here as completed

  • Florian Zill marked the checklist item Any new feature or behaviour change was documented? as completed

    marked the checklist item Any new feature or behaviour change was documented? as completed

  • Tobias Meisel
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading