The problem with the heap allocated array is that the ownership
is not clear. In the MeshEditing.Prism2Quad unit-test the
array of nodes was used after it has been already deleted
after element construction. Using array is safer and avoids
unnecessary heap alloctions.

Move implementation to cpp in anonymous namespace.

Dmitri Naumov authored 3 years ago and Dmitri Naumov committed 3 years ago

And with it all of the checks and recalculations are obsolete
and removed too.

Replace first part of the query with isBaseNode() as in
previous commits.
Use getNumberOfBaseNodes in calculation of "active" (regular) nodes.

Dmitri Naumov authored 3 years ago and Dmitri Naumov committed 3 years ago

The new implementation uses only local topology information to
distinguish base and "higher" order nodes.

Dmitri Naumov authored 3 years ago and Dmitri Naumov committed 3 years ago

The latter relies on local information of element types
and number of nodes, not the global numbering of nodes.

The connection information can be computed
on the fly required.

Rename setNodesConnectedByElements to
calculateNodesConnectedByElements and make it a free
function. This 'out sourcing' makes it possible to
compute the connection information only when it is
required.

Tom Fischer authored 3 years ago and Dmitri Naumov committed 3 years ago

# Conflicts:
#	MeshLib/Elements/Element.cpp
#	MeshLib/Elements/TemplateElement.h