Skip to content
Snippets Groups Projects

[Tests] better code quality in TH2M py notebooks

Merged Florian Zill requested to merge FZill/ogs:notebooks into master
  • replaced vtuIO with ogstools
  • added assertions
  • reduced repetitions
Edited by Florian Zill

Merge request reports

Merged results pipeline passed for a694d591

Deployed to web prev‎iew 5217‎ 1 month ago

Merged by Dmitry Yu. NaumovDmitry Yu. Naumov 1 month ago (Feb 3, 2025 1:17pm UTC)

Loading

Pipeline #27563 failed

Pipeline failed for 6b250440 on master

Test coverage 78.50% from 0 jobs
10 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dmitry Yu. Naumov
  • Code changes look reasonable; didn't look at the output. The two minuscule comments from my side can be ignored.

    Edited by Dmitry Yu. Naumov
  • Dmitry Yu. Naumov approved this merge request

    approved this merge request

  • Tobias Meisel
  • mentioned in merge request ogs/tools/ogstools!233 (closed)

  • Tobias Meisel
  • Tobias Meisel
  • Florian Zill added 1 commit

    added 1 commit

    • ee0fb4b4 - [Tests] better code quality in TH2M py notebooks

    Compare with previous version

  • Florian Zill reset approvals from @endJunction by pushing to the branch

    reset approvals from @endJunction by pushing to the branch

  • Florian Zill mentioned in issue #3522

    mentioned in issue #3522

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading